Skip to content

5.0.1 & 4.6.23 releases #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: 5.0
Choose a base branch
from
Open

5.0.1 & 4.6.23 releases #2880

wants to merge 12 commits into from
+112 −7

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Aug 19, 2025 •
edited
Loading

Question Answer
JIRA Ticket
Versions 5.0.1, 4.6.23
Edition

Note: To list the classes affected by stricter method signature type hinting is time consuming, and the resulting list itself will be too long to be useful to the reader.

Related PR: ibexa/documentation-user#372

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

adriendupuis
adriendupuis commented Aug 19, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

Preview of modified files

Preview of modified Markdown:

adriendupuis
adriendupuis commented Aug 22, 2025
View reviewed changes
@adriendupuis adriendupuis marked this pull request as ready for review August 27, 2025 07:59
@adriendupuis adriendupuis requested a review from a team August 27, 2025 07:59
@ezrobot ezrobot requested review from adamwojs, mikadamczyk, Steveb-p, alongosz, ciastektk, ViniTou, barw4, wiewiurdp, konradoboza and tbialcz and removed request for a team August 27, 2025 07:59
adamwojs
adamwojs reviewed Aug 28, 2025
View reviewed changes
dabrt
dabrt reviewed Aug 28, 2025
View reviewed changes
@dabrt dabrt requested review from adamwojs and dabrt August 28, 2025 08:12
mnocon
mnocon reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple of suggestions

Could you also bump the variables in user doc? https://github.com/ibexa/documentation-user/blob/5.0/mkdocs.yml#L196-L197

docs/release_notes/ibexa_dxp_v5.0.md Outdated
Comment on lines 46 to 48
#### Pagination for ibexa_object_relation_list in GraphQL

To improve performance and gain greater control over the returned responses from the [GraphQL API](graphql.md), you can now [enable pagination](relationlistfield.md#enable-pagination-in-graphql) of relations specified using the RelationList field type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see https://doc.ibexa.co/en/5.0/content_management/field_types/field_type_reference/relationlistfield/#enable-pagination-in-graphql (and #2874)

The parameter is removed, the pagination is enabled by default.

I'd remove this section (or just mention that the pagination is enabled by default)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this section in 4c10a72 as this is not a change from 5.0.1

docs/release_notes/ibexa_dxp_v5.0.md
#### Pagination for ibexa_object_relation_list in GraphQL

To improve performance and gain greater control over the returned responses from the [GraphQL API](graphql.md), you can now [enable pagination](relationlistfield.md#enable-pagination-in-graphql) of relations specified using the RelationList field type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could mention the changes to discounts as well - on v5 it's no longer an LTS update, so the same changes could be mentioned here (I mean:

documentation-developer/docs/release_notes/ibexa_dxp_v4.6.md

Lines 44 to 54 in c2696b7

#### Global discount codes limits
- You can now [limit the number of times](discounts_guide.md#discount-codes) a discount code can be used before it expires. The discounts created before this release are set to unlimited global usage
#### Discount codes prioritization
- Discounts with discount codes now have priority over the other discounts
#### Discount codes migrations
- You can now create discount codes using [data migrations](importing_data.md#discount-codes)
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4c10a72 but in one section's list.
@mnocon Is it OK for you?

docs/release_notes/ibexa_dxp_v5.0.md Outdated

To improve performance and gain greater control over the returned responses from the [GraphQL API](graphql.md), you can now [enable pagination](relationlistfield.md#enable-pagination-in-graphql) of relations specified using the RelationList field type.

#### Other upgrades
Copy link
Contributor

@mnocon mnocon Sep 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I tried to mention new PHP API changes, for example:

documentation-developer/docs/release_notes/ibexa_dxp_v4.6.md

Lines 33 to 38 in c2696b7

#### PHP API
The PHP API has been enhanced with the following new classes:
- [`Ibexa\Contracts\ProductCatalogSymbolAttribute\Search\Criterion\SymbolAttribute`](https://doc.ibexa.co/en/4.6/api/php_api/php_api_reference/classes/Ibexa-Contracts-ProductCatalogSymbolAttribute-Search-Criterion-SymbolAttribute.html)
- [`Ibexa\Contracts\ProductCatalogSymbolAttribute\Value\ChecksumInterface`](https://doc.ibexa.co/en/4.6/api/php_api/php_api_reference/classes/Ibexa-Contracts-ProductCatalogSymbolAttribute-Value-ChecksumInterface.html)

We could mention the 3 new classes from #2882 (comment) (skipping Collaboration for now)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4c10a72

julitafalcondusza
julitafalcondusza reviewed Sep 2, 2025
View reviewed changes
julitafalcondusza
julitafalcondusza reviewed Sep 2, 2025
View reviewed changes
julitafalcondusza
julitafalcondusza reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@julitafalcondusza julitafalcondusza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark.
Don't take the second comment into account, as it's not part of the scope of this PR (I wanted to delete the comment, but due to a technical problem I can't).

@adriendupuis
Copy link
Contributor Author

Looks good overall, just a couple of suggestions

Could you also bump the variables in user doc? https://github.com/ibexa/documentation-user/blob/5.0/mkdocs.yml#L196-L197

Thank you for the review.

Variables were increased in 8477d3b
@mnocon Did I missunderstood something?

@adriendupuis adriendupuis requested a review from mnocon September 2, 2025 08:31
mnocon
mnocon approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mnocon
Copy link
Contributor

mnocon commented Sep 2, 2025

Looks good overall, just a couple of suggestions
Could you also bump the variables in user doc? https://github.com/ibexa/documentation-user/blob/5.0/mkdocs.yml#L196-L197

Thank you for the review.

Variables were increased in 8477d3b @mnocon Did I missunderstood something?

The variables are correctly bumped here, in the dev doc.

I meant the user documentation, which has its own set of variables: https://github.com/ibexa/documentation-user/blob/5.0/mkdocs.yml#L196-L197

@adriendupuis adriendupuis mentioned this pull request Sep 2, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@mnocon mnocon mnocon approved these changes

@konradoboza konradoboza konradoboza approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@ciastektk ciastektk Awaiting requested review from ciastektk

@ViniTou ViniTou Awaiting requested review from ViniTou

@barw4 barw4 Awaiting requested review from barw4

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

@tbialcz tbialcz Awaiting requested review from tbialcz

@dabrt dabrt Awaiting requested review from dabrt

Assignees
No one assigned
Labels
Needs DOC review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adriendupuis @mnocon @adamwojs @alongosz @konradoboza @dabrt @julitafalcondusza